agusalex / ghostfolio-sync

Sync Ghostfolio with IBKR
34 stars 9 forks source link

Move symbol mapping to file to pull req #23

Closed Trefex closed 4 months ago

Trefex commented 4 months ago

Summary by Sourcery

This pull request introduces a new configuration file 'mapping.yaml' for symbol mappings, enhances the SyncIBKR class to load these mappings dynamically, and adds support for specifying the IBKR platform ID via an environment variable. Documentation has been updated to reflect these changes.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request introduces a new configuration file (mapping.yaml) for symbol mappings, allowing for dynamic symbol transformation without modifying the code. The SyncIBKR class has been updated to load these mappings, and the documentation has been updated to reflect these changes. Additionally, the main script has been modified to pass the new configuration parameters.

File-Level Changes

Files Changes
SyncIBKR.py
README.md
main.py
mapping.yaml
Introduced a new configuration file (mapping.yaml) for symbol mappings, updated SyncIBKR class to load and use these mappings, and updated documentation and main script to support the new configuration.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.