search

agusalex / ghostfolio-sync

Sync Ghostfolio with IBKR
34 stars 9 forks source link

Move symbol mapping to file #24

Closed Trefex closed 4 months ago

Trefex commented 4 months ago

Summary by Sourcery

This pull request introduces a new configuration file mapping.yaml for symbol mappings, updates the SyncIBKR class to load these mappings, and enhances the sync_ibkr method to use the mappings for symbol transformation. Additionally, documentation has been updated to reflect these changes and provide instructions for using the new configuration file.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request refactors the symbol mapping logic by moving it to an external YAML file (mapping.yaml). The SyncIBKR.py script is updated to load this file and use the mappings dynamically, replacing the previous hardcoded logic. Additionally, the README.md file is updated to include instructions for using the new mapping file and running the container with Podman.

File-Level Changes

Files Changes
SyncIBKR.py
mapping.yaml		 Moved symbol mapping logic to an external YAML file (mapping.yaml) and updated SyncIBKR.py to load and use these mappings dynamically.
README.md Updated documentation to include instructions for using the new symbol mapping file and running the container with Podman.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
agusalex commented 4 months ago

Applied some minor changes, thanks again!