preview/harModel.js Loader unused code?

[GoogleCodeExporter]

In preview/harModel.js, I see:

HarModel.Loader =
{
    run: function(callback, errorCallback)
    {
        var baseUrl = Lib.getURLParameter("baseUrl");

        // Append traling slahs if missing.
        if (baseUrl && baseUrl[baseUrl.length-1] != "/")
            baseUrl += "/";

        var paths = Lib.getURLParameters("path");

...

        // The URL can specify also a locale file (with the same domain).
        // http://domain/har/viewer?path=<local-file-path>
        var filePath = Lib.getURLParameter("path");

so it looks like the bottom bit of code won't be used since the above path will 
always handle the path parameter.

Original issue reported on code.google.com by adrian...@gmail.com on 10 Mar 2011 at 9:11

[GoogleCodeExporter]

Correct, it's removed at r232

Thanks!
Honza

Original comment by odva...@gmail.com on 10 Mar 2011 at 10:11

• Changed state: Commit

[GoogleCodeExporter]

sorry it's R233
Honza

Original comment by odva...@gmail.com on 10 Mar 2011 at 10:12

[GoogleCodeExporter]

I guess then the next question is whether or not localLocalArchive is needed 
anymore ;)

Original comment by adrian...@gmail.com on 10 Mar 2011 at 10:14

[GoogleCodeExporter]

Oops, my mistake (I should have tested it before commit). I needed to revert 
the R233 since the code is still needed. Try to load e.g.

http://legoas/har/viewer/webapp/?path=examples/inline-scripts-block.har

Honza

Original comment by odva...@gmail.com on 10 Mar 2011 at 10:30

• Changed state: New

[GoogleCodeExporter]

Oops, sorry my bad, didn't look closely enough:

        if ((baseUrl || inputUrl) && urls.length > 0)
            return this.loadRemoteArchive(urls, callbackName, callback, errorCallback);

that doesn't happen since baseUrl isn't set.

Original comment by adrian...@gmail.com on 10 Mar 2011 at 10:47

[GoogleCodeExporter]

no problem, closing.
Honza

Original comment by odva...@gmail.com on 10 Mar 2011 at 2:19

• Changed state: Invalid