search

aguschin / art-guide

Your guide in the world of art
MIT License
8 stars 2 forks source link

Text to speech #41

Closed daisymint closed 1 year ago

aniervs commented 1 year ago

Looks good to me, thanks! I'm not merging because it potentially updates can break the telegram bot. Leaving this up to you @aniervs since you're the only one who can check it works now.

You see, at this stage, given that we aren't using the saved audios, and we are generating them on the fly, I believe this PR should not be merged. Right now we're still using Google TTS. I would recommend keeping this PR open at least until Friday morning, and instead of merging it, create a simpler PR with just the README of the text2speech_module.

@daisymint @aguschin

It's just too late in the night for me to try to merge and fix potential issues, although the code seems quite clean.

aguschin commented 1 year ago

Totally agree @aniervs. Didn't think you'll work on this right away. It's way too late now.