agusmakmun / django-log-viewer

Django Log Viewer allows you to read & download log files in the admin page
https://pypi.org/project/django-log-viewer/
MIT License
74 stars 30 forks source link

Update logfile_viewer.html for Django 3.0 #5

Closed squio closed 4 years ago

squio commented 4 years ago

load admin_static was deprecated in favor of load static and completely removed in Django 3.0

agusmakmun commented 4 years ago

@squio unfortunately in the django template it doesn't have a try except. so we can't handle multiple versions.

squio commented 4 years ago

@squio unfortunately in the django template it doesn't have a try except. so we can't handle multiple versions.

Would this be a backward compatibility problem for Django 2.2? Or for 1.x? This issue is the only one left for our app before migrating to Django 3.0 so it would be great if this can be merged in the next release

agusmakmun commented 4 years ago

@squio I checked at the doc says, this feature has deprecated since django 2.1. I think it not a big problem for django >= 2.1. I'll merge your great P.R :+1:

https://docs.djangoproject.com/en/2.2/releases/2.1/#features-deprecated-in-2-1

{% load staticfiles %} and {% load admin_static %} are deprecated in favor of {% load static %}, which works the same.

squio commented 4 years ago

Thanks! Could you please create a new release so we can upgrade directly from PyPi?

agusmakmun commented 4 years ago

@squio well done.