agutoli / react-styled-select

A Select control built with Reactjs, styled-components and :heart: http://agutoli.github.io/
MIT License
108 stars 23 forks source link

Make Styled-Components A Peer Dependency #28

Closed willisplummer closed 6 years ago

willisplummer commented 6 years ago

šŸ‘‹ This PR makes styled-components a peer dependency. Consumers of this library are presumably already using styled-components in their top level projects, and running two versions of styled-components on a page can cause unexpected results.

https://github.com/styled-components/styled-components/issues/1032 https://github.com/styled-components/styled-components/issues/633

I'm currently aliasing styled-components in my project with webpack to avoid using both versions but as I update styled-components I will be running the risk of introducing breaking changes that this library doesn't support.

There's more info here: https://www.styled-components.com/docs/faqs#i-am-a-library-author-should-i-bundle-styledcomponents-with-my-library

Hope this is helpful + please LMK if you have any questions.

Also, if you're open to it, we've been running this package with versions of styled-components as recent as 3.3, so it could be helpful to bump the version or just expand the range of acceptable peer versions

agutoli commented 6 years ago

Hi, @willisplummer. Thank you! It was merged and published.

new version 1.2.1

agutoli commented 6 years ago

I added you to Collaborators. Is it ok? Thank you.

Collaborators List