search

agutoli / serverless-layers

Serverless.js plugin implementing AWS Lambda Layers, reducing lambda size, warm-up, and deployment time.
MIT License
229 stars 54 forks source link

fix not copying files before installation #37

Closed Capelinha closed 4 years ago

Capelinha commented 4 years ago

I found that placing the '.npmrc' file in copyBeforeInstall solves my problem with the private repositories but there is a bug in copying the files before installation. This if is never executed when the file exists.

Capelinha commented 4 years ago

I just realized that there are two pull requests correcting the same thing. I spent time debugging and understanding how it works for nothing. 😆

agutoli commented 4 years ago

Hi @Capelinha. Thanks for your PR. As you said it already has two PR with same fix. I accepted first one that is doing exactly same fix that you made.

I appreciate.

PR: https://github.com/agutoli/serverless-layers/pull/33