agzam / mw-thesaurus.el

Merriam-Webster Thesaurus in Emacs
GNU General Public License v3.0
100 stars 9 forks source link

What about at least two, one-keystroke, extras.. #6

Closed touxstone closed 5 years ago

touxstone commented 5 years ago

Hi, first compliments for such a gorgeous and so useful tool, though what about some extra, one-keystroke, scroll-down and scroll-up functionalities by adding e.g. to line 181 the following 2:

          (local-set-key [backspace] 'scroll-down)
          (local-set-key " " 'scroll-up) 
agzam commented 5 years ago

I'd like to avoid adding default keybindings, since everyone has different preferences. You still can customize mw-thesaurus-mode-map in your config, no?

agzam commented 5 years ago

@touxstone I'm going to close this. I hope you'd understand.

touxstone commented 5 years ago

@touxstone I'm going to close this. I hope you'd understand.

It's fine (no problem, as for me) I had not taken that into consideration but after you mention it I assent, you're right. Alternatively, if anyone wanted to include the mentioned extras here the lines to add somewhere | its equivalent .emacs.d/init.el

(progn "adding more kbd facilities to mw-thesaurus-mode-map that I cannot otherwise"
       (define-key mw-thesaurus-mode-map [backspace] 'scroll-down)
       (define-key mw-thesaurus-mode-map " " 'scroll-up))