search

agzam / mw-thesaurus.el

Merriam-Webster Thesaurus in Emacs
GNU General Public License v3.0
100 stars 9 forks source link

In "RET lookup for the word", RET should be C-c C-o #9

Open xuchunyang opened 5 years ago

xuchunyang commented 5 years ago

https://github.com/agzam/mw-thesaurus.el/blob/aaa4b7b71b5b08535c294cad1517863167f97fa8/mw-thesaurus.el#L64

org-open-at-point is bound to C-c C-o not RET by default. Maybe you just want to bind RET directly without remap?

agzam commented 5 years ago

In evilified buffers RET is bound to org-open-at-point. So doing this I think will break it for Spacemacs and Doom users.

xuchunyang commented 5 years ago

I've never used Evil. If you want to RET, you can just use it, it should work for everybody, right? e.g.,

(define-key mw-thesaurus-mode-map (kbd "RET") #'mw-thesaurus--lookup-at-point)
agzam commented 5 years ago

No, I'm pretty sure that's the reason why I did it that way in the first place. I wanted it to be in Org-mode, using outline worked, but it wasn't looking as nice, and in evilified org-mode buffer, RET wouldn't work as I wanted. I know, that's probably not the right way, but it works.

xuchunyang commented 5 years ago

You want RET to run mw-thesaurus--lookup-at-point, right?

and then

(define-key mw-thesaurus-mode-map (kbd "RET") #'mw-thesaurus--lookup-at-point)

doesn't work for you?

mooseyboots commented 1 year ago

i also have this issue. not using evil, RET doesn't work for me.