search

agzam / spacehammer

Hammerspoon config inspired by Spacemacs
MIT License
567 stars 70 forks source link

regression: window undo appears to be broken #127

Closed agzam closed 3 years ago

agzam commented 3 years ago

It looks like at some point windows/undo stopped working. Not a vital feature, but we probably should have a better strategy for deprecating existing functionality :)

A cursory glance did not show me any clues.

jaidetree commented 3 years ago

What is the expected behavior?

Grazfather commented 3 years ago

Any chance you can find the culprit with git bisect?

agzam commented 3 years ago

So when you move/maximize/center window, it pushes it into the history stack, then when you undo, it should restore the window to the previous state (size and coords). Right now, I see the message in the console:

** Warning:  bind.fnl: Could not invoke action windows:undo-action
jaidetree commented 3 years ago

Thanks! That error means that if you have a binding like windows:undo-action in config.fnl, it can't find the corresponding function that the string refers to.

Replace windows:undo-action with windows:undo, I'll make a PR to make the error message more clear and update the default config.

Did write some notes on a potential migration system in #122

agzam commented 3 years ago

Thank you @eccentric-j. It's both - embarrassing and heartwarming to find myself having to catch up with the new development. I can hardly keep up with you guys. You are awesome!