search

agzam / spacehammer

Hammerspoon config inspired by Spacemacs
MIT License
556 stars 70 forks source link

fixes jump-window #150

Open agzam opened 2 years ago

agzam commented 2 years ago

Bug discovered while testing #149. Upstream. Looks like it's broken in Hammerspoon. Removed usage of the experimental module.

https://github.com/agzam/spacehammer/pull/149#issuecomment-961617007

Grazfather commented 2 years ago

What version of Hammerspoon did you discover this on? I noticed there was an update just yesterday.

agzam commented 2 years ago

I'm using Hammerspoon Version 0.9.91 (6078) I have not upgraded OS to Monterey yet, supposedly they made some fixes for it. I guess it broke very recently. Then let's not merge this thing just yet. Like Sun Tzu would've said: "If you wait by the river long enough, you may see fixed bugs floating by."

HyunggyuJang commented 2 years ago

I encountered the same issue, and was able to resolve with https://github.com/HyunggyuJang/Spacehammer/commit/dbb12cded518c7a7960fcf885ba2e92521e913a1

I’m not sure it is the canonical solution and works for all, so I’d like to know your opinions about it!

agzam commented 2 years ago

For me - both cases work. And whatever is in the master branch - doesn't. Even though I'm now using version 0.9.93 (6148) - it's still broken. At this point, I think we have to merge a fix - using either method. However, I've noticed another thing - after jumping to the target window, Spacehammer menu doesn't go away. That looks like a regression. I'll check what's going on there.

Grazfather commented 2 years ago

I can't repro on 6172. Do you still have this issue?

agzam commented 2 years ago

I can't repro on 6172. Do you still have this issue?

The latest available release is 0.9.93 (6148) - both on GitHub and via brew. How did you get 6172?

Grazfather commented 2 years ago

It was created to test a fix for an issue I reported Hammerspoon/hammerspoon#3081 https://github.com/Hammerspoon/hammerspoon/actions/runs/1726174041

Grazfather commented 1 year ago

Is this still needed?

agzam commented 1 year ago

Is this still needed?

Yes, jump to window appears broken in master. But this "fix" doesn't seem to be fixing it for good. It works, but not reliably.