agzam / spacehammer

Hammerspoon config inspired by Spacemacs
MIT License
556 stars 70 forks source link

Once updated to fennel 1.0, 'fennelview' missing. #154

Closed Grazfather closed 1 year ago

Grazfather commented 2 years ago

According to the repo it's part of fennel now.

We can remove it from repl.fnl. Looks like it was left there accidentally.

Grazfather commented 2 years ago

If we just release a version that sets the min version of fennel to 1.x we can remove this. That's my recommendation.

agzam commented 2 years ago

Do you think we should assert the version programmatically? The only way [I have found so far] to read the version, is by doing something like this: (hs.execute "/usr/local/bin/fennel -v"). But we can't be sure that fennel is installed at that path. And I couldn't find any way of finding the executable in the path; things like (hs.execute "where fennel"), etc., don't seem to work.

Grazfather commented 2 years ago

We can do this:

>> (. (require :fennel.utils) :version)
"1.1.0"

Though if we want to check it properly we have to parse it as a semantic version... lazily we can just make sure the first int is >= 1?

Grazfather commented 1 year ago

Done in da5dde7