search

ah- / anne-key

Firmware for Anne Pro Keyboard written in Rust
Apache License 2.0
567 stars 32 forks source link

Fix brightness/animation_speed and Add LED functions to FN layer #15

Closed MvEerd closed 6 years ago

MvEerd commented 6 years ago

This PR fixes next_brightness and next_animation_speed being switched around and adds LED functions to the FN layer where they would be in the stock firmware

I like the idea of having a new layer for LED and be able to jump to themes directly but was confused by FN+R/T/Y/U not working initially, I hope this helps more people try the firmware as drop-in replacement

ah- commented 6 years ago

Oh thanks, this is looking useful!

The LedOn Action means something slightly different so far, I think on the original FW it turns the LED chip on automatically when you try and talk to it. Would still keep it as you have it atm, best we can do right now.

The separate layer was mainly for initial development, much easier with just a toggle so I didn't have to keep holding down the FN key.

MvEerd commented 6 years ago

Thanks for the feedback! I did indeed consider that the LedOn function does not quite behave like the original firmware I will work towards a LedToggle function instead to combine LedOn and LedOff

The original firmware does indeed turn on the LEDs to the last used theme when pressing FN+R, you currently have to switch to the next theme to get LEDs to turn on in this firmware

I've tried sending [0, 0, 0] over serial after LedOn but that does not seem to do the trick, I'm open to suggestions otheriwse I'll try some things until I get the ST-link debugger

hdhoang commented 6 years ago

I've tried sending [0, 0, 0] over serial after LedOn but that does not seem to do the trick, I'm open to suggestions otheriwse I'll try some things until I get the ST-link debugger

I had the impression that there's no debugging without ST-link & OpenOCD. Could you add your development setup to a CONTRIBUTING.md file or the README? Thanks!

MvEerd commented 6 years ago

I'm moreso doing trial and error than any actual debugging unfortunately @hdhoang 😅 Your contributions to README actually helped me set up the environment to compile so I have you to thank for that 👍 The only thing that confused me was having to add -2018-03-02 but your PR to fix travis quickly explained that