search

ah- / rdkafka-dotnet

C# Apache Kafka client
Other
242 stars 73 forks source link

Allow specifying a segment of the payload for produce #81

Closed MaximGurschi closed 4 years ago

MaximGurschi commented 7 years ago

Hello Andreas,

Would you consider a pull request that allows specifying a segment of the payload bytes to send? This is to avoid buffer copying. It will require some unsafe code though.

ah- commented 7 years ago

Good timing. There was/is a PR implementing exactly that: https://github.com/ah-/rdkafka-dotnet/pull/79 and https://github.com/ah-/rdkafka-dotnet/pull/73

I'll have a look as soon as a find some time, if you test it it'll certainly go in quicker.

MaximGurschi commented 7 years ago

Happy to test.

MaximGurschi commented 7 years ago

Are you waiting for me to test the PR before implementing this?

ah- commented 7 years ago

Hi, I'm just waiting to have some time to do some minimal sanity checks. If you have time please test, that'll speed things up.