ahamez / protox

A fast, easy to use and 100% conformant Elixir library for Google Protocol Buffers (aka protobuf)
MIT License
271 stars 19 forks source link

[BUG] Could not start application propcheck #201

Closed squirmy closed 1 month ago

squirmy commented 1 month ago

Describe the bug Thanks for making a release :)

After updating to 1.7.6 I now get this error when running my app:

** (Mix) Could not start application propcheck: could not find application file: propcheck.app

Is there additional configuration I need to specify?

To Reproduce Steps, code or protobuf messages to reproduce the behavior:

  1. mix deps.update protox
  2. mix phx.server

Expected behavior

Phoenix server starts.

Environment (please complete the following information): Hex: 2.1.1 Elixir: 1.17.3 OTP: 25.3.2.13

ahamez commented 1 month ago

🤔 It seems I got things mixed up with the key extra_applications.

Can you try with {:protox, github: "ahamez/protox", ref: "173ea1a"} (you should erase the deps directory before)?

On my side, with the following mix.exs, it works when running mix phx.server:

defmodule Foo.MixProject do
  use Mix.Project

  def project do
    [
      app: :foo,
      version: "0.1.0",
      elixir: "~> 1.17",
      start_permanent: Mix.env() == :prod,
      deps: deps()
    ]
  end

  # Run "mix help compile.app" to learn about applications.
  def application do
    [
      extra_applications: [:logger]
    ]
  end

  # Run "mix help deps" to learn about dependencies.
  defp deps do
    [
      {:protox, github: "ahamez/protox", ref: "173ea1a"},
      {:phoenix, "~> 1.7"}
    ]
  end
end
squirmy commented 1 month ago

Yep, that works perfectly.

Thanks!

ahamez commented 1 month ago

Great! It's now published in 1.7.7 :-)