search

ahand / mobileesp

MobileESP
Apache License 2.0
172 stars 77 forks source link

detectNintendo in Python checks same thing 3 times #13

Closed brabadu closed 8 years ago

brabadu commented 8 years ago

in python module UAgentInfo.deviceNintendo in self.__userAgent is repeated 3 times.

    def detectNintendo(self):
        """Return detection of Nintendo
        Detects if the current device is a Nintendo game device.
        """
        return UAgentInfo.deviceNintendo in self.__userAgent \
            or UAgentInfo.deviceNintendo in self.__userAgent \
            or UAgentInfo.deviceNintendo in self.__userAgent

In previous versions it was 

        return UAgentInfo.deviceNintendo in self.__userAgent \
            or UAgentInfo.deviceWii in self.__userAgent \
            or UAgentInfo.deviceNintendoDs in self.__userAgent
ahand commented 8 years ago

Thank you very kindly for writing about this issue! I've fixed it in the main branch.