search

ahand / mobileesp

MobileESP
Apache License 2.0
173 stars 77 forks source link

mdetect.py violates PEP8 coventions #3

Open geoom opened 9 years ago

geoom commented 9 years ago

According PEP8 function names convention:

Function names should be lowercase, with words separated by underscores as necessary to improve readability.

mixedCase is allowed only in contexts where that's already the prevailing style (e.g. threading.py), to retain backwards compatibility.

About variables:

Use the function naming rules: lowercase with words separated by underscores as necessary to improve readability.

Please, keep conventions for compatibility with projects that uses this great utlity.

ahand commented 9 years ago

Thanks for bringing this to my attention.

How big of a deal is this...?

The Python library was originally ported by a member of the MobileESP community, so I'm not familiar with the language and its conventions.

I'll be honest, though. Using camel case makes things a lot easier for me to maintain the cross-language code! :-)