search

ahand / mobileesp

MobileESP
Apache License 2.0
172 stars 77 forks source link

Fixed the WP8.1 / IE11 bug on the JavaScript library. IE11 has in the… #8

Open LuigiQuarta opened 8 years ago

LuigiQuarta commented 8 years ago

… user agent both android and iphone and that caused it to be detected in a wrong way. Here the details: http://www.neowin.net/news/ie11-fakes-user-agent-to-fool-gmail-in-windows-phone-81-gdr1-update

ahand commented 8 years ago

@Zoimaru: Thanks for making some commits. I was aware of this issue and was feeling ambivalent about it... As a result, I didn't address it in the last round of updates.

When making a fix, it's important to apply consistent logic across the code libraries. You correctly used the DetectWindowsPhone() method in the JavaScript library. However, you used a different method for the Java library.

We must also make consistent updates across the entire MobileESP code base so that the behavior is as consistent as possible across programming language.

Would you like to take a stab at applying the code update to the other libraries, too?

LuigiQuarta commented 8 years ago

@ahand I've made the change consistent for the Java version using detectWindowsPhone10() instead the user agent check, I didn't noticed the method on Java the first time, my fault!

I've updated also the Python and PHP files, about the ASP and CPP I think is better someone else help on this part.