ahangarha / Awesome-Books

GNU Affero General Public License v3.0
1 stars 0 forks source link

Refactor to use js classes #2

Closed ahangarha closed 2 years ago

ahangarha commented 2 years ago

Description

Implement the project with JavaScript classes

General requirements

HTML/CSS requirements

Feel free to remove the item(s) not related to this PR.

Project requirements

Additional notes

There was a mistake in pushing in main branch which has been reverted.


Thank you for taking the time to review this pull request.

ahangarha commented 2 years ago

@Mihndim2020 Thanks for your review but I think you reviewed without checking anything in this PR.

We don't have a single linter issue. We have an issue with merge conflict issue which I explained above and also in the review request. I was expecting the reviewer help with its resolution not rejecting the PR without checking it at all.

ahangarha commented 2 years ago

We just used cherry-pick commits to a new branch and made a new PR. So this PR is not valid any more.