search

ahankinson / pybagit

Python library for manipulating bagit files.
http://ahankinson.github.io/pybagit
Other
20 stars 8 forks source link

Added update flag to allow skipping known files when calculating hashes #8

Closed wolph closed 8 years ago

wolph commented 8 years ago

It's quite a hefty change but I think a useful one. In addition to the standard workflow of re-checksumming all files on update it is now possible to skip the known files and only checksum the new files.

ahankinson commented 8 years ago

Could you tell me if the unit tests pass? Should they be updated?

wolph commented 8 years ago

The unit tests pass but it doesn't currently have a specific test for this code yet.

For automated testing it actually would be good if Travis support was included, it's pretty easy to set up, should I give it a go?

ahankinson commented 8 years ago

Sure!

wolph commented 8 years ago

Travis is doing it's job but it appears it's somehow stalling with Python 2.6, I've just disabled it for now. Nobody uses 2.6 anyhow.

The status for my repository: https://travis-ci.org/WoLpH/pybagit After merging it you can enable travis for your repository as well, once you do it will automatically test all pull requests for you and tell you if the tests succeed.

ahankinson commented 8 years ago

Would it be too much to ask to break out the Travis functionality from the update changes? I'd like a chance to test the update changes myself, but would like to merge the Travis stuff asap.

wolph commented 8 years ago

No problem at all, I'll just cherry pick them into a new branch :)

On 7 October 2015 at 21:17, Andrew Hankinson notifications@github.com wrote:

Would it be too much to ask to break out the Travis functionality from the update changes? I'd like a chance to test the update changes myself, but would like to merge the Travis stuff asap.

— Reply to this email directly or view it on GitHub https://github.com/ahankinson/pybagit/pull/8#issuecomment-146300803.

ahankinson commented 8 years ago

Thanks!