Closed xslim closed 9 years ago
Good points. Let me first migrate the tests in branch devel from OCTest to XCTest.
I can redo my work on top of devel branch if needed. Also, maybe it's easier to do tests in plain C and skip invoking Xcode? Same as I did (see Makefile and .travis)
I will have a deeper look at it tomorrow.
I will integrate the changes in the devel branch. The tests are considering different scenarios (OS X, iOS, framework builds, Objective-C++); I will add a C scenario there.
I think ther's no big need in uint32_t
as size of int
is quite enough for all components that you might imagine in a normal app / library...
Right. It's more about using a type with a well-defined size, instead of a compiler/platform-specific type.
Indeed, I agree, including stdint
will work
Please try the latest version from the devel branch.
A default _lcl_logger
implementation is not there yet.
Seems OK for me, the only thing I would add is:
[@__FILE__ lastPathComponent]
with a FILENAME
macro (from my pull request)C
type (fsprintf
) with probably configurable #define _lcl_c_out stderr
The last one has at least one interesting use cases:
<os/trace.h>
See WWDC 2014, session 714, "fix_bugs_faster_using_activity_tracing"
Will continue on this in the next days.
What's the use-case for the default level?
1, 2, and 4 are in.
Use case of default level - well, by default, the log is off as it's not configured... Adding a default configuration can help "quickstart"
Hmm, you can set the value for all components via e.g. lcl_configure_by_identifier("*", lcl_vTrace);
. Adding an additional default level has the negative effect that we need to check two trace-levels: the component's level and the default level.
@xslim can you try the current code from the devel branch, please? If everything works for your scenario, then we could go for a 1.4.1 release.
Will do tomorrow)
Sent from my iPhone
On Nov 23, 2014, at 13:52, Arne Harren notifications@github.com wrote:
@xslim can you try the current code from the devel branch, please? If everything works for your scenario, then we could go for a 1.4.1 release.
— Reply to this email directly or view it on GitHub.
@xslim did you have a chance to take a look?
Seems fine to me
I think you can make a release.
Good catch with __has_include
, it's not available on some compilers.
We are integrating the logging system in our big C project on embedded platform currently... I hope by Tuesday I can make a note how that worked.
ok, I'll wait; we're not in a hurry :)
@xslim any news on this?
Yep, it works)
Sent from my iPhone
On 10 Jan 2015, at 08:43, Arne Harren notifications@github.com wrote:
@xslim any news on this?
— Reply to this email directly or view it on GitHub.
will try to release the new version on the weekend
This is a basic conversion to allow LLC work in plain old C apps. Work done:
__OBJC__
for includingFoundation
fprintf
tostdout
as basic logger if used in C or_LCL_LOG_C_STRING
definedlcl_config_*
files are available, and if not - add one default "Main" componentlcl_vError
orlcl_vInfo
ifDEBUG
clib install stephenmathieson/describe.h
make