search

ahartmanns / qcomp

qcomp.org – Quantitative Model Repository and Tool Comparison
http://qcomp.org/
6 stars 7 forks source link

Firewire abst comment typo #104

Closed davexparker closed 2 years ago

davexparker commented 3 years ago

The rounds property in the firewire_abst MDP model has a typo.

"Maximum" should be "minimum" in the comment, to avoid confusion.

https://github.com/ahartmanns/qcomp/blob/master/benchmarks/mdp/firewire_abst/firewire_abst.props#L3

This is also in the description field in the index.json file.

https://github.com/ahartmanns/qcomp/blob/master/benchmarks/mdp/firewire_abst/index.json#L48

I already fixed this is in the PRISM benchmark suite.

Strictly speaking, it's actually the property that is wrong, not the comment. But the "minimum" variant is still vaguely meaningful and it seems preferable not to change properties retrospectively if possible.

ahartmanns commented 2 years ago

Fixed in d7ca281f8ffd6e01ed101c5b39a059551a41d801.