search

ahausladen / JsonDataObjects

JSON parser for Delphi 2009 and newer
MIT License
413 stars 160 forks source link

Should line not use 'JsonMemInfoMainBlockStart' instead of 'JsonMemInfoBlockStart' #56

Closed ronaldhoek closed 4 years ago

ronaldhoek commented 4 years ago

Accidentally stumbled upon this:

https://github.com/ahausladen/JsonDataObjects/blob/72a25adc508387a2797980b5ed963e00f6d1ebc0/Source/JsonDataObjects.pas#L1156

Should that line not use JsonMemInfoMainBlockStart instead of JsonMemInfoBlockStart?

ronaldhoek commented 4 years ago

Thanks, but the currently referenced 'fix' points to different commit (which does not show the fix).

It should be: https://github.com/ahausladen/JsonDataObjects/commit/2ddcef634c0a4c070c2cda55d060b7287d029a47

ahausladen commented 4 years ago

Somehow I committed two "Fixed #56". I never intended to commit the *.dproj file changes. I can't fix this without rewriting the history what will break the git repository for others.

ronaldhoek commented 4 years ago

No problem, it's now referenced using my comment ;)