search

ahawker / ulid

Universally Unique Lexicographically Sortable Identifier (ULID) in Python 3
Apache License 2.0
695 stars 42 forks source link

Update/fix docs: timestamp().datetime always returns a UTC datetime #481

Closed mfogel closed 4 years ago

mfogel commented 4 years ago

Hi, thanks for the nice ULID lib

The docs appear to be a bit out-of-sync with the implementation. timestamp().datetime is set up to always return a UTC datetime (that's good!) but the docs don't reflect that. This PR fixes the docs to match that implementation.

Cheers, thanks again for the project

codecov[bot] commented 4 years ago

Codecov Report

Merging #481 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #481   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          547       547           
  Branches        80        80           
=========================================
  Hits           547       547

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c07998b...b9428e9. Read the comment docs.

ahawker commented 4 years ago

@mfogel Thanks for catching that. Missed in #465.