Pull commits from Rallysf fork

ahawkins / cashier

Tag based caching for Rails using Redis. Associate different cached content with a tag, then expire by tag instead of key.

MIT License

162 stars 39 forks source link

Pull commits from Rallysf fork #10

Closed joeytheman closed 11 years ago

joeytheman commented 12 years ago

Can you take a look at Rallysf branch and see about pulling in some of their commits?

I believe https://github.com/rallysf/cashier/commit/8ac3725a2351e966b7267e6c24f90d89f14a9181 will solve issues #6 and #8.

joeytheman commented 11 years ago

I forked Rallysf branch and fixed the test framework among a few other changes. Let me know if you would like pull requests. https://github.com/joeytheman/cashier.git

ahawkins commented 11 years ago

Can you send a PR? The commit looks good.

EDIT: Nevermind. This repo doesn't even have cashier/application_controller nor does it integrate directly with ActionController. What's the point?

joeytheman commented 11 years ago

They changed a few things. See 641e1f41ab5dcbcea83acc7d169754fc93ef603b .

joeytheman commented 11 years ago

Any update on this?

ahawkins commented 11 years ago

@joeytheman have them send a PR and I will review it.