search

ahawkins / cashier

Tag based caching for Rails using Redis. Associate different cached content with a tag, then expire by tag instead of key.
MIT License
162 stars 39 forks source link

ApplicationController methods not inherited when installing Gem #12

Closed constantm closed 11 years ago

constantm commented 11 years ago

Just stumbled across a weird issue - when installing the Gem, it seems I'm not able to access any methods defined in ApplicationController from other controllers. Any ideas why this would happen?

ahawkins commented 11 years ago

This does not make any sense. Can you provide a test app? On Nov 30, 2012 5:19 PM, "Constant Meiring" notifications@github.com wrote:

Just stumbled across a weird issue - when installing the Gem, it seems I'm not able to access any methods defined in ApplicationController from other controllers. Any ideas why this would happen?

— Reply to this email directly or view it on GitHubhttps://github.com/twinturbo/cashier/issues/12.

tinylox commented 11 years ago

I have a similar problem I am using cashier along with inherited resources. I think that may have something to do with it. Looking at the ApplicationController definition in a pry session shows the cashier extensions to ApplicationController but my own apps local ApplicationController methods are not present.

InheritedResources::Base descends from ::ApplicationController and I think in this instance it is the inheriting from the cashier implementation before the local app version can add its methods to the class leading to other classes not having visibility to the apps ApplicationController defined methods. Ill see if I can put together an example app with this problem.

tinylox commented 11 years ago

Upon further investigation it appears that the problem is with the version of the gem hosted at rubygems.org. When updating the Gemfile to point to the latest on master things work fine as the application_controller.rb file has been removed. Is what is on master right now stable ? If so perhaps a minor version bump and deploy to rubygems is in order?

ahawkins commented 11 years ago

Yes it seems so. I will sort it out and release a new version. On Dec 7, 2012 4:51 PM, "Terrence Turner" notifications@github.com wrote:

Upon further investigation it appears that the problem is with the version of the gem hosted at rubygems.org. When updating the Gemfile to point to the latest on master things work fine as the application_controller.rb file has been removed. Is what is on master right now stable ? If so perhaps a minor version bump and deploy to rubygems is in order?

— Reply to this email directly or view it on GitHubhttps://github.com/twinturbo/cashier/issues/12#issuecomment-11134760.

ahawkins commented 11 years ago

If so perhaps a minor version bump and deploy to rubygems is in order?

@tinylox 0.4.1 just deployed. Sorry about that and for the delay :(