search

ahay / src

Main Madagascar source
Other
264 stars 173 forks source link

[BUG] Possible misplacement of brackets #191

Closed Sh0lim closed 4 years ago

Sh0lim commented 4 years ago

Hi,

when I run SConstruct from page http://www.reproducibility.org/RSF/book/cwp/geo2009VTIModeSeparation/paper_html/node8.html, I get error message as below.

scons: Reading SConscript files ... TypeError: can only concatenate list (not "str") to list: File "/home/work/Projects/Madagaskar/src-master/book/data/separate3/SConstruct", line 136: fdd.derivatives(par) File "/home/work/Projects/Madagaskar/src-master/book/Recipes/fdd.py", line 54: Flow('fdx',None,fdd.fdx(par)) File "/home/work/Projects/Madagaskar/src-master/book/Recipes/fdd.py", line 31: return list(filter('%s' %('0,'+s_coefm+',' +s_coefp ),par)) + '| transp'

Best,

Milos

sfomel commented 4 years ago

Thank you for reporting this bug.

This change should fix it: https://github.com/ahay/src/commit/30656887be4cd8b2bacd350777f26fe666e7f319#diff-ef9f92a8cec5071293be37a0398db188