search

ahayworth / python_awair

Python library for the Awair API
https://python-awair.readthedocs.io
MIT License
13 stars 6 forks source link

Capture firmware version from local devices #26

Closed zachberger closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #26 (e812a2c) into master (d3cff1c) will increase coverage by 0.03%. The diff coverage is 100.00%.

:exclamation: Current head e812a2c differs from pull request most recent head a3ed591. Consider uploading reports for the commit a3ed591 to get more accurate results

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   94.85%   94.88%   +0.03%     
==========================================
  Files          11       11              
  Lines         311      313       +2     
==========================================
+ Hits          295      297       +2     
  Misses         16       16
Impacted Files Coverage Δ
python_awair/devices.py 95.96% <100.00%> (+0.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zachberger commented 2 years ago

As per PEP484 Python 3.6 is EOL'd as of last December and is not receiving updates.

That being said, the code added still should work on Python 3.6. I can revert that part of the change. I'll let you make the decision.

balloob commented 2 years ago

Let's remove Python 3.6 support in a different PR and let's get this PR merged 👍

zachberger commented 2 years ago

Dropping Python 3.6 has been removed out of this PR