Hey, Rob here, feel free to message me on Slack if you want any clarification on the points below. I will give you both positive and constructive feedback on your project.
Requirements
A working Portfolio: The main task is to create a portfolio to showcase what you will be learning on the course and to give the visitors an insight to who you are.
Practice using Git and GitHub flow: We want you to get as much practice as possible using git, GitHub and the command line.
Apply what you learn in the morning: This is a great place to apply what you have been learning on the course.
Feedback
HTML: Good start with the HTML file. It seems as though you need to add a formatter such as prettier as an extension to VS Code as things seem a little out of place. You are using DIVs a lot where you could be using semantic elements such as headers/sections etc. Something to think about for the future
BEM: Good first attempt at BEM naming convention. You have got it right some of the time! Understanding what exactly are going to be your BLOCKS, ELEMENTS and MODIFIERS before you start writing too much code is a good idea. I feel like your blocks are a fraction too big and there are too many elements in play.
SCSS: Good use of partials, variables. This would have made the design process much faster/easier. I really like how you've separated your styling. Next project would be good to start thinking about how to keep your files tidy by using folders. Have a look at the 5-1 SCSS folder structure. When we are separating words for files we use a dash e.g. _aboutme.scss would have been _about-me.scss
Overall: You're off to a good start on this course. Keeping on top of deadlines is going to be a big goal for you. Keeping on top of deadlines means that you can focus on the learning each day as it is delivered instead of having to double back and focus on older projects. Keep up the good work and positive attitude.
ahaziem
commented
2 years ago
Feedback
Hey, Rob here, feel free to message me on Slack if you want any clarification on the points below. I will give you both positive and constructive feedback on your project.
Requirements
A working Portfolio: The main task is to create a portfolio to showcase what you will be learning on the course and to give the visitors an insight to who you are.
Practice using Git and GitHub flow: We want you to get as much practice as possible using git, GitHub and the command line.
Apply what you learn in the morning: This is a great place to apply what you have been learning on the course.
Feedback
HTML: Good start with the HTML file. It seems as though you need to add a formatter such as prettier as an extension to VS Code as things seem a little out of place. You are using DIVs a lot where you could be using semantic elements such as headers/sections etc. Something to think about for the future
BEM: Good first attempt at BEM naming convention. You have got it right some of the time! Understanding what exactly are going to be your BLOCKS, ELEMENTS and MODIFIERS before you start writing too much code is a good idea. I feel like your blocks are a fraction too big and there are too many elements in play.
SCSS: Good use of partials, variables. This would have made the design process much faster/easier. I really like how you've separated your styling. Next project would be good to start thinking about how to keep your files tidy by using folders. Have a look at the 5-1 SCSS folder structure. When we are separating words for files we use a dash e.g. _aboutme.scss would have been _about-me.scss
Overall: You're off to a good start on this course. Keeping on top of deadlines is going to be a big goal for you. Keeping on top of deadlines means that you can focus on the learning each day as it is delivered instead of having to double back and focus on older projects. Keep up the good work and positive attitude.