search

ahbnr / nixos-06cb-009a-fingerprint-sensor

Nix flake for driving the 06cb:009a fingerprint sensor on NixOS
31 stars 16 forks source link

python-validity: fix PyPA build #6

Closed deviant closed 10 months ago

deviant commented 1 year ago

Since https://github.com/NixOS/nixpkgs/pull/248866/commits/6c85fff302615c62bf4f632bca661bc48298b0a3, buildPythonPackage uses pypa{Build,Install}Hook for setuptools-based python packages rather than the older pip{Build,Install}Hooks. pypaInstallHook appears to have more stringent testing than its predecessor, yielding the following error:

FileExistsError: File already exists: /nix/store/[...]-python3.10-python-validity-0.14/share/dbus-1/system.d/io.github.uunicorn.Fprint.conf

Removing the workaround doesn't appear to cause problems, and seemingly works just fine with pipInstallHook as well: whatever necessitated its addition was presumably fixed in the interim, with installation of the resource files being silently duplicated, until now.

ahbnr commented 10 months ago

I cherry-picked the commit from this PR into https://github.com/ahbnr/nixos-06cb-009a-fingerprint-sensor/pull/8 and also applied the same change to the open-fprintd package, as well as upgraded nixpkgs to 23.11.

I squash-merged that other PR and so I would close this one. Using GitHub's Co-authored-by feature and the commit message, I tried to properly credit you. I hope this is alright with you.

deviant commented 10 months ago

That's fine, although I'd prefer in future if you just credited me as "V" (or @deviant) rather than using my GitHub username as a noun. ^^