search

ahcis-rds / study_finder

StudyFinder is a flexible and configurable application to pull studies from clinicaltrials.gov and augment the data from alternate datasources such as a clinical trials management system.
MIT License
17 stars 4 forks source link

Remove StudyFinder base inheritance #69

Closed johnsja closed 4 years ago

johnsja commented 4 years ago

Removing the StudyFinder base model inheritance from models. This eliminates the cumbersome and unnecessary prefixes. Each model already explicitly states the table name. It also eliminates the need to specify routes in forms as we're now using default routing, ex: ...simple_form_for(@user, :url => admin_users_path, :method => :post)... can now become ...simple_form_for [:admin, @user]...

cdinger commented 4 years ago

Thanks @johnsja. Can you check out the test failure?

https://travis-ci.org/github/ahcis-rds/study_finder/builds/697315623

johnsja commented 4 years ago

Sorry about that @cdinger, tests are passing now.