search

aheissenberger / serverless-appsync-offline

Serverless AWS AppSync Offline Plugin - Allow to run AppSync locally for serverless framework
MIT License
90 stars 25 forks source link

Quitting on Serverless 1.33 #8

Closed pianomansam closed 5 years ago

pianomansam commented 5 years ago

When running serverless appsync-offline start, ever since upgrading to Serverless 1.33, the command quits as soon as the GraphQL server comes up. From my logs, when using nodemon:

ℹ️  appsync-emulator:serverCore server bound { address: '::', family: 'IPv6', port: 62222 }
Serverless: AppSync started: http://localhost:62222/graphql
[nodemon] clean exit - waiting for changes before restart

You'll notice that while it exits cleanly, it doesn't do any of the cleanup. Otherwise we would see a line like AppSync offline - stopping graphql and dynamoDB.

I'm not sure if the bug is in this plugin or appsync-emulator-serverless.

aheissenberger commented 5 years ago

@pianomansam have a try with the updated AppSync Emulator

pianomansam commented 5 years ago

Using Serverless 1.34 doesn't cause this issue.

aheissenberger commented 5 years ago

@pianomansam thanks for updating this issue with this positive news :-)

mattgibson commented 5 years ago

Serverless 1.34.0 does cause this issue for me as well as the latest version, 1.37.1. If I downgrade to 1.32.0, then it's OK.

mattgibson commented 5 years ago

This seems to be the cause of the issue:

https://github.com/serverless/serverless/pull/5349/commits/a0a0fb1530fa17e9f215879dfdead88f61e46169

jaydp17 commented 5 years ago

@aheissenberger this issue does occur on the current master. I tried out @mattgibson's fix and it seems to work!!

Maybe we can merge the PR?

aheissenberger commented 5 years ago

@aheissenberger this issue does occur on the current master. I tried out @mattgibson's fix and it seems to work!!

Maybe we can merge the PR?

this is a fix to the serverless/serverless repository - you need to ask the serverless team to merge the fix

jaydp17 commented 5 years ago

@aheissenberger sorry, I didn't see that, thanks for informing.

aheissenberger commented 5 years ago

is fixed with version 1.3.2