aheit / cantools

GNU General Public License v3.0
56 stars 29 forks source link

Cantomat, result differ from canalyzer #12

Closed RasMH closed 7 months ago

RasMH commented 3 years ago

Hello I am converting a blf-file to mat with the help of three dbc-files. By comparing the output to a Canalyzer trace, I see that some message and signal names in the mat output does not match the ones shown in Canalyzer. To better judge which one is incorrect, I have also used the python cantools utitilty and it shows the same exact output as Canalyzer.

Here is the command I use to convert: cantomat -b2 -d BBA.dbc -b3 -d BBB.dbc -b11 -d BBC.dbc -B cantraffic.blf -pbm --verbose -t1 -m out.mat Here is the relevant output with cantomat:

Name: Ch11_DAQ1_TESTER_T_DAQ1_data Rank: 2 Dimensions: 33739 x 2 Class Type: Double Precision Array Data Type: IEEE 754 double-precision { 0.000326 3.84469e+09 0.001586 13 0.002894 3.35544e+09 0.005309 2.5574e+09

In Canalyzer I have this: image

Issue I want to pinpoint here is that cantomat output says DAQ1_TESTER_T instead of the expected DAQ1_TESTER_E. Signal values differ as well. Timestamps match as you see (and there are no other signals with the same timestamp). This is not the only frame that is different. I see a mismatch on about 40 frames compared to cantools. I have tried, but not been able to find a pattern, I get the wrong name on different channels and on both extended and short ids.

I may not be able to share the blf or dbc files, but I would be glad to assist in figuring out what the issue may be.

Cantomat version is 0.31. I compiled it on Ubuntu 20.04 under windows subsystem for linux (WSL). kind regards, Rasmus

aheit commented 2 years ago

Hello Rasmus,

thanks for the report and sorry for the late response.

Let me try to understand what is going wrong:

Let me try to ask some questions first.

Thanks,

Andreas

Von: RasMH @.> Gesendet: Donnerstag, 4. November 2021 11:23 An: aheit/cantools @.> Cc: Subscribed @.***> Betreff: [aheit/cantools] Cantomat, result differ from canalyzer (Issue #12)

Hello I am converting a blf-file to mat with the help of three dbc-files. By comparing the output to a Canalyzer trace, I see that some message and signal names in the mat output does not match the ones shown in Canalyzer. To better judge which one is incorrect, I have also used the python cantools utitilty and it shows the same exact ouput as Canalyzer.

Here is the command I use to convert: cantomat -b2 -d BBA.dbc -b3 -d BBB.dbc -b11 -d BBC.dbc -B cantraffic.blf -pbm --verbose -t1 -m out.mat Here is the relevant output with cantomat:

Name: Ch11_DAQ1_TESTER_T_DAQ1_data Rank: 2 Dimensions: 33739 x 2 Class Type: Double Precision Array Data Type: IEEE 754 double-precision { 0.000326 3.84469e+09 0.001586 13 0.002894 3.35544e+09 0.005309 2.5574e+09

In Canalyzer I have this: https://user-images.githubusercontent.com/12778717/140295913-5ec0eb7b-524f-4fae-8574-4f99a3b5ce29.png

Issue I want to pinpoint here is that cantomat output says DAQ1_TESTER_E instead of the expected DAQ1_TESTER_T. Signal values differ as well. Timestamps match as you see (and there are no other signals with the same timestamp). This is not the only frame that is different. I have tried, bu not been able to find a pattern, I get the wrong name on different channels and on both extended and short ids.

I may not be able to share the blf or dbc files, but I would be glad to assist in figuring out what the issue may be. kind regards, Rasmus

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aheit/cantools/issues/12 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBD72MH7XXH6UX5U3QPKNTUKJNGPANCNFSM5HLCOLRA . https://github.com/notifications/beacon/ABBD72KBZWAWG3YAE3QZFGTUKJNGPA5CNFSM5HLCOLRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4PSC63BA.gif

RasmusH-DS commented 2 years ago

Hi Andreas! Sorry for not being fully clear. I'll try again. Canalyzer says that the message on timestamp 0.000326 has the name DAQ1_TESTER_E and includes only 1 signal: DAQ1_data_E. Cantomat, for the same timestamp outputs the message name DAQ1_TESTER_T and the signal name is DAQ1_data (I had the flag -pmb when running cantomat)

Here are the id:s of the messages. image

I was able to strip the dbc-file to an absolute minimum that I can share. Do you have an email-adress I can send the blf and dbc-file to? I am not comfortable uploading them directly here.

In reality more messages differed between canalyzer and cantomat, but hopefully this will be enough to find the root cause.

aheit commented 2 years ago

Hello Rasmus,

yes, please send the files to @.***

I hope I can solve the problem with the files.

Thank you and regards, Andreas

Am Mi., 24. Nov. 2021 um 11:28 Uhr schrieb Rasmus H < @.***>:

Hi Andreas! Sorry for not being fully clear. I'll try again. Canalyzer says that the message on timestamp 0.000326 has the name DAQ1_TESTER_E and includes only 1 signal: DAQ1_data_E. Cantomat, for the same timestamp outputs the message name DAQ1_TESTER_T and the signal name is DAQ1_data (I had the flag -pmb when running cantomat)

Here are the id:s of the messages. [image: image] https://user-images.githubusercontent.com/94180493/143220809-15f41f02-d234-4928-97b3-9ab4df57b73e.png

I was able to strip the dbc-file to an absolute minimum that I can share. Do you have an email-adress I can send the data-file to? I am not comfortable uploading them directly here.

In reality more messages differed between canalyzer and cantomat, but hopefully this will be enough to find the root cause.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aheit/cantools/issues/12#issuecomment-977741590, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBD72PLI6PNYQVKJEITTZTUNS44RANCNFSM5HLCOLRA .

RasmusH-DS commented 2 years ago

Hi Andreas, It looks like the address got scrambled during publishing. I have sent the code to your gmail-account.

aheit commented 7 months ago

Hi Rasmus, I noticed that the issue is still open and I would like to close it. Did the commit of Dec 21, 2021 work for you?

aheit commented 7 months ago

update of Dec 21, 2021 implemented double type signals, closing the issue.