search

ahernp / django-feedreader

RSS Aggregator
BSD 3-Clause "New" or "Revised" License
90 stars 28 forks source link

added missing dependency (pytz) to install_requires #2

Closed zsoldosp closed 11 years ago

zsoldosp commented 11 years ago

Discovered after a clean setup on windows

Theoretically, the feedparser dependency could/should install it, but that doesn't happen for whatever reason. Also, since the feedreader code uses it directly, probably it should be included in this setup file too

Platform info to reproduce:

$ win_info OS Name: Microsoft Windows 7 Professional OS Manufacturer: Microsoft Corporation System Type: x64-based PC System Locale: en-us;English (United States) Input Locale: en-us;English (United States) $ python --version Python 2.7.4 $ virtualenv repro --no-site-packages $ source repro/Scripts/activate $ pip install django-feedreader $ pip freeze Django==1.5.4 django-feedreader==0.7.6 feedparser==5.1.3 $ git --version git version 1.8.1.msysgit.1

ahernp commented 11 years ago

I agree that this dependency should be included. Not to have done so was an oversight on my part.

Thank you Peter Zsoldos.

zsoldosp commented 11 years ago

Paul, great quick response, thanks!

Only after you merged the pull request did it occurr to me that the the version number in the setup.py file should also be increased... I don't know how often you publish to pypi, but changing behavior without changing release numbers usually causes issues.

ahernp commented 11 years ago

No problem, I'll change the version number in the code checked in to GitHub. I've already changed the version number loaded onto PyPi.

Paul Ahern +44 (0)776 037 2573 ahernp (skype) www.ahernp.com

On 18 October 2013 08:27, Peter Zsoldos notifications@github.com wrote:

Paul, great quick response, thanks!

Only after you merged the pull request did it occurr to me that the the version number in the setup.py file should also be increased... I don't know how often you publish to pypi, but changing behavior without changing release numbers usually causes issues.

— Reply to this email directly or view it on GitHubhttps://github.com/ahernp/django-feedreader/pull/2#issuecomment-26576611 .

zsoldosp commented 11 years ago

ah, cool!

On Fri, Oct 18, 2013 at 9:59 AM, Paul notifications@github.com wrote:

No problem, I'll change the version number in the code checked in to GitHub. I've already changed the version number loaded onto PyPi.

Paul Ahern +44 (0)776 037 2573 ahernp (skype) www.ahernp.com

On 18 October 2013 08:27, Peter Zsoldos notifications@github.com wrote:

Paul, great quick response, thanks!

Only after you merged the pull request did it occurr to me that the the version number in the setup.py file should also be increased... I don't know how often you publish to pypi, but changing behavior without changing release numbers usually causes issues.

— Reply to this email directly or view it on GitHub< https://github.com/ahernp/django-feedreader/pull/2#issuecomment-26576611> .

— Reply to this email directly or view it on GitHubhttps://github.com/ahernp/django-feedreader/pull/2#issuecomment-26577900 .

http://www.linkedin.com/in/zsoldosp :::: http://blog.zsoldosp.eu :::: http://twitter.com/zsepi