search

ahezard / NitroHax_Old

http://chishm.drunkencoders.com/NitroHax/
GNU General Public License v3.0
13 stars 3 forks source link

This pull request will merge the changes you suggested... #2

Closed ApacheThunder closed 8 years ago

ApacheThunder commented 8 years ago

I added the pause between slot power off and power on. This fixes card reset so that card init works even if the system is booted with a card already inserted. :D

I also fixed a minor typo with these lines in the slot power on and power off functions:

In slot power off function on first line: Old: while(_SCFG_MC&0x0C == 0x0C); // wait until state<>3 Fixed: while(_SCFG_MC&0x0C != 0x0C); // wait until state<>3

In slot power on function on first line:

Old: while(_SCFG_MC&0x0C == 0x0C); // wait until state<>3 New: while(_SCFG_MC&0x0C != 0x0C); // wait until state<>3

This change was suggested by Normmatt. Changing it to this did not break anything so he was right. :D

ahezard commented 8 years ago

I am not convinced by this change In slot power off function on first line: Old: while(SCFG_MC&0x0C == 0x0C); // wait until state<>3 Fixed: while(SCFG_MC&0x0C != 0x0C); // wait until state<>3

In slot power on function on first line:

Old: while(SCFG_MC&0x0C == 0x0C); // wait until state<>3 New: while(SCFG_MC&0x0C != 0x0C); // wait until state<>3

But if nothing is broken, ok

ApacheThunder commented 8 years ago

Yeah you can leave that change out if you think it's fine as is. Normmatt brought it up and I had made that change. Didn't notice any negative effect. :P