search

aheze / Popovers

A library to present popovers. Simple, modern, and highly customizable. Not boring!
MIT License
1.97k stars 113 forks source link

Arrow extends over rounded corner #40

Open Eckelf opened 2 years ago

Eckelf commented 2 years ago

Hi,

after running the example app and trying out the standard showroom I've noticed the following: Standard arrow

The arrow extends over the rounded corner. Looking at the code it is supposed to be fixed by using an "arrowSidePadding" but I guess something isn't working correctly? I also see this issue when I integrate it into my app.

When changing the padding to 2.0 from 1.8 the issue is fixed. Maybe something has changed in the layout at some point?

Version: 1.3.2 Xcode 13.4 iOS 15.5

aheze commented 2 years ago

Indeed, when I was making this template I ran into the exact same problem, hardcoding a padding of 1.8...

Screen Shot 2022-06-06 at 9 10 29 PM

Not sure what I might have changed to cause this, I'll investigate. Maybe a device size issue?

ConfusedVorlon commented 2 years ago

Just noting that I found exactly the same bug using Popovers on iOS 15.5 Adjusting the arrowSidePadding fixed the issue for me

2.1 seems to be about the minimum for me - though I think it looks better with a slightly larger padding

(note - I'm using the default corner radius)