ahinchman1 / TornadoFX-Suite

Automated user-interaction testing for TornadoFX
20 stars 6 forks source link

Stage{2}@Bug: general refacorings #47

Open tieskedh opened 4 years ago

tieskedh commented 4 years ago

JoinToString

PR: #41 extension-PR: tieskedh/TornadoFX-Suite#2 Reason: index of a list cannot be greater than the size of the list, probably incorrect code?

collection-extensions

PR: #42

Map.withDefault:

PR: #43 At this moment, the default is in the map and only works with getvalue. It's also possible to use a normal map and use getOrDefault

replace split with substring-functions

PR: #44 Is more readible. If you also removed other segments, then it's not the same...

redundant size-check

PR: #45

getOrPut

PR: #46 Extension-PR: tieskedh/TornadoFX-Suite#1 reason: At this moment every /* ... / can be extracted in it's own function, if I'm correct. That is inconsistent with the extension-PR