ahlersml / MyCleaningLog

2 stars 2 forks source link

Code Review 2 #49

Open bentaohe opened 2 years ago

bentaohe commented 2 years ago

Analysis of the program This app will help you track the cleaning of the house for each room. Was the program available in UC Github on time? Yes Is the program documented/commented well enough for you to understand? Yes Does the program compile? Yes Rationale behind your changes. Some changes to make sure the formats are correct and in standard. Also I removed the cleaning from cleaningTask. Task is a more flexible name, and is PascalCase. I also add a Javadoc to kick off the FirebaseUI sign in flow. Three specific commits 46e079b2b72d444a9d5fbee26503cd7a9b32b922 52a43b38e1776fb6bf8b77eb63e58ddb69dc92f3 81c68e16fcc11a3a8ed69351c941940f69440fdc three specific technical concepts that I learned

  1. How to add sign-in to your Android app with FirebaseUI.
  2. How to use Javadoc.
  3. How to make the format nice and clean.
discospiff commented 2 years ago

From this review: