ahlstromcj / sequencer64

A major reboot of Seq24. Current release 0.97.0 (2021-05-13), native JACK MIDI, Song recording, playlists, and a Windows/Qt version. For fresher code, see the Seq66 project. Note that trigger and mute-group-in-MIDI-file formats have evolved! Back up your work!
GNU Affero General Public License v3.0
237 stars 28 forks source link

Grid snap does not work in song mode #171

Open AndrewPy opened 5 years ago

AndrewPy commented 5 years ago

(I use Sequencer64 0.96.1 compiled on Ubuntu 18.04 64bit.)

The grid snap function does not work in song mode. If I insert a pattern, it is inserted at the cursor position, no matter which grid snap setting I use.

I compared it with the old seq24 and there it works as expected.

(In sequencer64 I can move it to the next grid snap position with the cursor keys, but then the timing for the pattern is completely wrong.)

ahlstromcj commented 5 years ago

I have a tentative fix in the qt5_reconcile branch. Still need some cleanup but you are welcome to test it.

On Tue, Feb 5, 2019, 01:46 AndrewPy <notifications@github.com wrote:

(I use Sequencer64 0.96.1 compiled on Ubuntu 18.04 64bit.)

The grid snap function does not work in song mode. If I insert a pattern, it is inserted at the cursor position, no matter which grid snap setting I use.

I compared it with the old seq24 and there it works as expected.

(In sequencer64 I can move it to the next grid snap position with the cursor keys, but then the timing for the pattern is completely wrong.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ahlstromcj/sequencer64/issues/171, or mute the thread https://github.com/notifications/unsubscribe-auth/AHnVqNkDGaKh9ODYd4p5661oERmn8gB_ks5vKSjggaJpZM4aioKZ .

AndrewPy commented 5 years ago

Thank you for your effort!

I built seq64 from the qt5_reconcile branch today, but sorry to say something is still not right.

In the old seq24 song editor: I can insert a pattern at the 1/1 positions only. After that I can move it (following the grid snap setting). The pattern begins to play at the beginning (of this pattern) and if i move the pattern back to a 1/1 position, the timing goes back to normal.

In the seq64 song editor: The pattern is inserted at exactly the position of the mouse cursor (ignoring the grid snap setting) - so it is nearly impossible to insert it at an 1/1 position. After that I can move it though (following the grid snap setting), but the timing is not right - even if i put it to a 1/1 position the timing stays wrong and the pattern does not start to play from the beginning but instead somewhere in the middle.