ahlstromcj / sequencer64

A major reboot of Seq24. Current release 0.97.0 (2021-05-13), native JACK MIDI, Song recording, playlists, and a Windows/Qt version. For fresher code, see the Seq66 project. Note that trigger and mute-group-in-MIDI-file formats have evolved! Back up your work!
GNU Affero General Public License v3.0
235 stars 29 forks source link

Pattern Editor: Moving the left vertical notes does not move the grid #197

Open wundermusiker opened 4 years ago

wundermusiker commented 4 years ago

Ubuntu 19.10 from KX Repo

When I use the pattern Editor and move the grid, the notes move as well. When I accidently move the notes verticaly, then the grid stays in place.

Built Feb 1 2020 13:33:32 C++ version 201402 App name: qseq64; type qt; engine rtmidi Build OS: 'Linux 4.4.0-174-generic #204-Ubuntu SMP Wed Jan 29 06:41:01 UTC 2020 x86_64' Native JACK/ALSA (rtmidi) Event editor Follow progress bar Highlight edit pattern Highlight empty patterns JACK session JACK support Seq32 chord generator, LFO window, menu buttons, transpose BPM Tap button, solid piano-roll grid Song performance recording Optional pattern coloring Multiple main windows Pause support Save time-sig/tempo 64-bit

Options are enabled/disabled via the configure script, libseq64/include/seq64_features.h, or the build-specific seq64-config.h file in include or in include/qt/portmidi

wundermusiker commented 4 years ago

Just compiled myself the GTK Version. No issues. Only the QT Version affected

ahlstromcj commented 4 years ago

I finally duplicated/understood the issue and am looking into it. Right now the qscrollmaster feeds the scrollbar changes to seqkeys/qseqkey, but there is no feeding the keys scroll position back to the scrollmaster. While I am researching, there is a workaround.... move the vertical scrollbar at the right, and the keys will scroll to the correct position. I will assiduously research this issue until I reach a dead end.

I've also fixed an issue in configure for Debian Sid, which uses gcc/g++/cpp version 9 by default, but which has a nasty bug where cpp can't find limits.h. It never ends with GNU software! Love it though we do. :-)

ahlstromcj commented 4 years ago

The fix is a workaround. Ideally, moving the piano keys (qseqkeys) up and down would pass the events to the qscrollmaster so that it could also move the piano roll (qseqroll) up and down. But currently, qseqkeys doesn't have access to the qscrollmaster. Not sure that it's worth it. However, at some point we would like to use the scroll wheel more generally.