ahmadalli / vscode-nginx-conf

:pencil: VS Code extension: Nginx config file hint(auto-completion)
GNU General Public License v3.0
24 stars 3 forks source link

Do not remove empty lines #22

Open binarykitchen opened 2 months ago

binarykitchen commented 2 months ago

Nice extension, thanks for that.

Just one issue I'd like to raise: it removes empty lines too much.

For example:

# some examle
proxy_buffers           288 224k;

# some example
proxy_buffer_size       6144;

# some example
set                     $proxyCacheByPass 1;

But your extension makes it harder to read, it removes all the empty lines to:

# some examle
proxy_buffers           288 224k;
# some example
proxy_buffer_size       6144;
# some example
set                     $proxyCacheByPass 1;

Please do not remove empty lines. Empty lines help us developers to separate issues, our eyes are tired looking at the computer monitor every day.

Env configuration

I can think of two solutions: (a) Add an empty line before each comment; or (b) Implement a new option to configure this.

Thanks