ahmadawais / WPGulp

An advanced Gulp workflow for WordPress development with extensive documentation. Used by 40,000+ themes and plugins.
https://twitter.com/MrAhmadAwais/
MIT License
1.77k stars 303 forks source link

Potential gulp Improvements #113

Closed ataylorme closed 5 years ago

ataylorme commented 6 years ago

I just found this project - stellar job on making something so great! I see in v2 the project was updated to use gulp 4.

WP Rig recently went through a gulp 4 overhaul for the upcoming 1.1 version.

See this pull request for the list of all the improvements made.

I think quite a few of them, such as using pump, loading plugins and splitting tasks into separate files, could be implemented in WPGulp as well.

Would you be interested in having any of the gulp 4 improvements we made to WP Rig in WPGulp?

ahmadawais commented 6 years ago

I just found this project - stellar job on making something so great! I see in v2 the project was updated to use gulp 4.

@ataylorme nice to finally e-meet you. I think I heard about you/your work at Pantheon from David. So, 👋 fellow dev 🥑.

WP Rig recently went through a gulp 4 overhaul for the upcoming 1.1 version. See this pull request for the list of all the improvements made.

Just went through it.

I think quite a few of them, such as using pump, loading plugins and splitting tasks into separate files, could be implemented in WPGulp as well. Would you be interested in having any of the gulp 4 improvements we made to WP Rig in WPGulp?

I'd be looking forward to your PR's. Make sure that you follow Emoji Log for your git commit messages. It's how this project is maintained since after v1.3.

Looking forward, peace! ✌️

ataylorme commented 6 years ago

@ahmadawais thanks for the quick reply. Nice to "meet" you as well!

Understood that the project is aimed at beginners so the change we want is to use pump instead of pipe (see the gulp 4.0.0 docs on why use pump).

ahmadawais commented 6 years ago

Definitely go ahead with pump. 👍👋