search

ahmadawais / corona-cli

🦠 Track the Coronavirus disease (COVID-19) in the command line. Worldwide for all countries, for one country, and the US States. Fast response time (< 100ms). https://x.com/MrAhmadAwais
https://NodeCLI.com
MIT License
1.85k stars 191 forks source link

📦 NEW: limit functionality to cli #17

Closed firasdib closed 4 years ago

firasdib commented 4 years ago

Implements the feature described in https://github.com/ahmadawais/corona-cli/issues/16

ahmadawais commented 4 years ago

Definitely, we should only use absolute positive values.

ahmadawais commented 4 years ago

I suggest using something like https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/abs Just turn the negative value to positive one.

ahmadawais commented 4 years ago

Thanks for the PR. Can you please update the PR in light of the latest release.

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0 🔗 https://www.npmjs.com/package/corona-cli

firasdib commented 4 years ago

Looks like some pretty major changes were made, and I'm not sure I'm the right person to fix this, even though I did the changes...

firasdib commented 4 years ago

I gave it a go. Have a look and see if you agree with the changes.

ahmadawais commented 4 years ago

Oh dang, again needs to be rebased.

firasdib commented 4 years ago

Rebased again..

ahmadawais commented 4 years ago

No worries, I had rebased them on my end already.

ahmadawais commented 4 years ago

Thank you!

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.6.0 🔗 https://www.npmjs.com/package/corona-cli

I chose -l as the alias.

peschee commented 4 years ago

The help text is off:

   --limit, -n          Limit output to N entries

The alias is still displayed as -n, -l works.

ahmadawais commented 4 years ago

Dang it. I thought I had removed it.

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.8.4 🔗 https://www.npmjs.com/package/corona-cli

npm i -g corona-cli