ahmadawais / corona-cli

🦠 Track the Coronavirus disease (COVID-19) in the command line. Worldwide for all countries, for one country, and the US States. Fast response time (< 100ms). To chat: https://twitter.com/MrAhmadAwais/
https://NodeCLI.com
MIT License
1.85k stars 191 forks source link

NEW: Implement full JSON output, without changing existing logic #76

Closed mifkata closed 4 years ago

mifkata commented 4 years ago

issue #11

Overview

This PR is about changing the output format from Table to JsonOutput (a simplified Json formatter). It doesn't change anything about current logic in regards to data fetching and sorting. The only difference is that:

How to test

mifkata commented 4 years ago

@ahmadawais Hello, just a friendly reminder to review this :) Thank you!

ahmadawais commented 4 years ago

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/5.1.0 🔗 https://www.npmjs.com/package/corona-cli

Thanks a lot @mifkata for working on this.

One improvement I can think of is that the keys for JSON could be

country, cases, 'cases-today', deaths, 'deaths-today', recovered, active, critical, 'per-million'.

mifkata commented 4 years ago

One improvement I can think of is that the keys for JSON could be

country, cases, 'cases-today', deaths, 'deaths-today', recovered, active, critical, 'per-million'.

Do you want me to open a PR for it @ahmadawais ? :)

ahmadawais commented 4 years ago

Sure thing.