search

ahmadawais / shades-of-purple-vscode

🦄 Shades of Purple offers a hand-picked selection of bold and vibrant shades of purple that will transform your code into a visually stunning masterpiece. With its carefully crafted color palette, this theme brings a sense of style, elegance, and whimsy to your favorite code editor, making your coding sessions a delightful journey of creativity.
https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple
Other
719 stars 64 forks source link

Shades of Purple theme is either overriding or not specifying default markup textMateRules #57 #105

Closed smcenlly closed 3 years ago

smcenlly commented 3 years ago

Describe the bug Theme is either overriding or not specifying default markup textMateRules that are provided with VS Code default themes. This breaks syntax highlighting in extensions that use these rules.

To Reproduce Steps to reproduce the behavior:

  1. Clone https://github.com/smcenlly/missing-textmate-tokens VS Code sample extension.
  2. Open the repo and run npm install
  3. Open the repo in VS Code and Start debugging (F5).
  4. Create a new file (Ctrl + N).
  5. Change its language to markup using the Change Language Mode command
  6. Paste the contents below:
deleted

inserted

underline
  1. Using any of the VS Code themes, you will see output similar to: Working Example

Expected behavior Theme should provide similar formatting (adjusted to its themes). Instead, no highlighting is displayed.

image

smcenlly commented 3 years ago

Bumping this issue - any plans to fix?

ahmadawais commented 3 years ago

This was an extremely helpful bug report. I just published a fix in v6.12.1. Thank you! 🙌

🔗 https://github.com/ahmadawais/shades-of-purple-vscode/releases/tag/6.12.1 🏁 Done (in 20s.)