search

ahmadawais / shades-of-purple-vscode

🦄 Shades of Purple offers a hand-picked selection of bold and vibrant shades of purple that will transform your code into a visually stunning masterpiece. With its carefully crafted color palette, this theme brings a sense of style, elegance, and whimsy to your favorite code editor, making your coding sessions a delightful journey of creativity.
https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple
Other
733 stars 62 forks source link

Diff view looks weird #14

Closed alankritjoshi closed 6 years ago

alankritjoshi commented 6 years ago

Love your theme. Only gripe with it that I have is the diff view. It looks messed up with a green outline for each line, not sure if it is intended

screen shot 2018-09-10 at 2 20 41 pm
ahmadawais commented 6 years ago

@alankritjoshi thanks for reaching out. It's very much intended. Outline is how you find out about changes in the same line. Give me a better example and I'll try my best to make 🦄 Shades of Purple better.

alankritjoshi commented 6 years ago

Oh cool, this seems to be something similar to one of the high contrast themes in Code. I was expecting a background highlight kind of thing because lines reduce visibility for me personally:

screen shot 2018-09-10 at 4 25 12 pm

I am rocking this theme regardless! Thanks for your contribution and for sharing on dev.to

ahmadawais commented 6 years ago

This is what it looks like without borders. That you can also do that by yourself by putting this in the settings.

"workbench.colorCustomizations": {
        "diffEditor.insertedTextBorder": "#00FF000E",
        "diffEditor.removedTextBorder": "#FF000D1A",
    }

WITHOUT image

WITH BORDERS image

I like it with borders, without borders it's too dull.

Peace! ✌️

ansemjo commented 5 years ago

I :heart_eyes: this theme! However, this is the one thing that kinda looks weird to me.

I agree that without the borders it looks dull. On the other hand the sheer number of borders when you have many changed lines in one block looks messy, too. If there was a way to collapse intersecting borders so they do not appear bolder than the rest, that would help a lot, I believe.

Toning the borders down a bit and instead brightening the background, the override that I am currently using:

{
  ...
  "workbench.colorCustomizations": {
        "[Shades of Purple]": {
            "diffEditor.insertedTextBorder": "#0f04",
            "diffEditor.insertedTextBackground": "#0f02",
            "diffEditor.removedTextBorder": "#f004",
            "diffEditor.removedTextBackground": "#f002"
        }
    }
}