search

ahmadawais / shades-of-purple-vscode

🦄 Shades of Purple offers a hand-picked selection of bold and vibrant shades of purple that will transform your code into a visually stunning masterpiece. With its carefully crafted color palette, this theme brings a sense of style, elegance, and whimsy to your favorite code editor, making your coding sessions a delightful journey of creativity.
https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple
Other
733 stars 62 forks source link

editor.findMatchBackground default color problem #24

Closed kaosmos closed 5 years ago

kaosmos commented 5 years ago

Hello there, I'm having a lot of readability problems with the default highlight color for search results. It is a fully saturated orange (i.e. #FF7200) and, especially with some code highlights, the search result is very hard to read.

I attach a screenshot to show my point:

color_highlight_difficulties

I'm currently overriding this in my settings.json but I'd prefer a more readable color in the theme.

ahmadawais commented 5 years ago

@kaosmos what color would you suggest? I have seen that with syntax highlighting this orange colors works the best. It's the same that Google Search & Chrome use.

kaosmos commented 5 years ago

@ahmadawais yes I noticed it :) but Google Search and Chrome usually highlights a black text and this color works but in your boldly (and very pleasing, I have to say) mixed palette there are too many different colors to cope with. Right now I'm using #DAD5F6, it is a very very light version of your chosen foreground color, not completely satisfied but it works better for me.

ahmadawais commented 5 years ago

@kaosmos yes, that #DAD5F6 works too. I seriously threw many shades of purple on the search highlight but nothing worked as good with all the different colors.

I am going to keep this issue open in hope that someone will make a better suggestion than what we have right now. I don't like it either — but with most colors, it does the highlighting.

Also, glad to see you like the theme. Can I ask for a 🌟 five-star rating this helps me with the theme discovery for so many devs out there?

Also, not sure if you've got a chance to check out the course I just released, easily my best work, it's called VSCode.pro — worked quite hard on this course and if you ever think of supporting my work — buying this course would be the right way to do it.

Peace! ✌️

kaosmos commented 5 years ago

Also, glad to see you like the theme. Can I ask for a 🌟 five-star rating this helps me with the theme discovery for so many devs out there?

Absolutely, I just did it, and thank you for making this theme available to the rest of us

ahmadawais commented 5 years ago

@kaosmos Thank you, for sharing the feedback and this review! 😇

kaosmos commented 5 years ago

@ahmadawais, a quick heads up on this. Now VS Code support opacity for background colors, now my match highlight is:

"editor.findMatchHighlightBackground": "#FF7200A0"

ahmadawais commented 5 years ago

Thanks for letting me know. I just pushed an update 👍

kaosmos commented 5 years ago

❤️ lovely, also I like the slightly different color you chose. thank you

ahmadawais commented 5 years ago

Yeah, I wanted the color to pop a little. Peace! ✌️