ahmadawais / shades-of-purple-vscode

🦄 Shades of Purple offers a hand-picked selection of bold and vibrant shades of purple that will transform your code into a visually stunning masterpiece. With its carefully crafted color palette, this theme brings a sense of style, elegance, and whimsy to your favorite code editor, making your coding sessions a delightful journey of creativity.
https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple
Other
737 stars 62 forks source link

Keep colour of bold/italic text in Markdown #43

Closed rdhar closed 5 years ago

rdhar commented 5 years ago

Another question, is there any reasoning for changing the colour of bold or italic text from the regular white to light-purple colour in Markdown?

I really appreciate how the text changes its font-weight or font-style depending on bold or italic formatting but it seems odd that it changes colour as well, especially to a lower contrasting one.

When you're reading the rendered Markdown output, bold/italic text appear in the exact same colour, just different formatting, so one would think that the raw Markdown equivalent would keep the bold/italic text in white but just change its formatting as appropriate. As with other places, I think it's best to retain to the dark ** on either side though, to keep a similar effect with the unobtrusive # for headings.

Thanks for your time.

rdhar commented 5 years ago

If there's a custom User Settings that can be toggled to compare this against (i.e., keep bold+italic text white in Markdown), that'd be really appreciated as well. Thanks!

ahmadawais commented 5 years ago

Sure, looking into this.

You can give it a try

        {
            "name": "[MARKDOWN] - Color for Emphasis Bold",
            "scope": "markup.bold.markdown",
            "settings": {
                "fontStyle": "bold",
                "foreground": "#A599E9"
            }
        },
        {
            "name": "[MARKDOWN] - Color for Emphasis Italic",
            "scope": "markup.italic.markdown",
            "settings": {
                "fontStyle": "italic",
                "foreground": "#A599E9"
            }
        },

This goes in the same token setting I sent you in that other issue.

Above are the current settings. You can just remove the foreground to see white.

BEFORE ↓

AFTER ↓

Not sure what to do here :P

ahmadawais commented 5 years ago

I dunno — purple looks much more fun and clear to me. What about you?

rdhar commented 5 years ago

image

I gotta say, I'm digging the look of white-coloured emphasised text. To me, it seems to flow better in a sentence rather than drastically changing colours in between. But that's just me; better to get other opinions first before making anything official :)

PS: I wonder if you'd happen to know how to control the Font Weight of Markdown text that's formatted in bold (or anything else that's styled bold, like Markdown headers)? Similar to fontStyle, I was hoping that fontWeight exists, but that doesn't seem to be the case.

Wonder if this text-decoration property is available under some other name by any chance?

ahmadawais commented 5 years ago

After using it for a couple of days, I tend to somewhat agree on keeping the colors same so I made that default.

DONE Published ahmadawais.shades-of-purple@5.8.0 Your extension will live at https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple (might take a few seconds for it to show up).