Please add support for Operator Mono SSm Lig

MajhiRockzZ commented 5 years ago

I love❤ Shades of Purple. But I'm always switching between Night Owl and Shades of Purple just because Shades of Purple lack feature for Operator Mono SSm Lig

ahmadawais commented 5 years ago

Howdy, @MajhiRockzZ

The ligature is a font feature. It doesn't really have anything to do with the theme. Can you share with me exactly what's missing? I'd be happy to add it in the theme.

A more detailed answer would go a long way to help here.

MajhiRockzZ commented 5 years ago

NightOwlEx

ShadesOfPurpleEx

Ligature are fine. Need help with fonts.

NightOwlImport

ShadesOfPurpleImport

ahmadawais commented 5 years ago

That's not a font-related thing. 🦄 Shades of Purple theme is not overly italic that's all. I am slowly building an italic version along with the default one. You can italicize whatever you want.

We have an issue regarding that here https://github.com/ahmadawais/shades-of-purple-vscode/issues/8

You can add something like this in your settings to get these itallics.


"editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "name": "[ITALICS] REMOVED",
                "scope": [
            "italic",
                "keyword.control",
                "quote",
                "storage",
                "modifier",
                "this",
                "comment",
                "support.type.property-name",
                "entity.other.attribute-name",
                "punctuation.definition.comment",
                "text.html.basic entity.other",
                "markup.quote",
                "markup.italic",
                "meta.tag.sgml.doctype",
                "punctuation.binary",
                "markup.changed",
                "meta.diff.header",
                "meta.diff.header.from-file",
                "meta.diff.header.to-file",
                "markup.deleted.diff",
                "markup.inserted.diff",
                "meta.delimiter.period",
                "punctuation.accessor",
                "meta.var.expr",
                "meta.class meta.method.declaration meta.var.expr storage.type",
                "variable.other.object.property",
                "entity.name.tag.doctype",
                "meta.tag.sgml.doctype",
                "entity.name.section",
                "meta.selector",
                ],
                "settings": {
                    "fontStyle": "italic"
                }
            }
        ]
    }

ahmadawais commented 5 years ago

Feel free to help build that italic version here https://github.com/ahmadawais/shades-of-purple-vscode/blob/master/themes/shades-of-purple-color-theme-italic.json

MajhiRockzZ commented 5 years ago

Thank You ⚡ for your kind support.💝 Those settings really worked well for me. I will be super happy to help build that italic version of this theme.

This is how my editor looks ri8 now (pretty cool) : Screenshot_1

ahmadawais / shades-of-purple-vscode

Please add support for Operator Mono SSm Lig #72