search

ahmadawais / shades-of-purple-vscode

🦄 Shades of Purple offers a hand-picked selection of bold and vibrant shades of purple that will transform your code into a visually stunning masterpiece. With its carefully crafted color palette, this theme brings a sense of style, elegance, and whimsy to your favorite code editor, making your coding sessions a delightful journey of creativity.
https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple
Other
719 stars 64 forks source link

Enable semantic highlighting for the Shades of Purple themes #90

Open aeschli opened 4 years ago

aeschli commented 4 years ago

Since 1.43, VSCode themes can take advantage of semantic highlighting.

Every theme controls whether semantic tokens are enabled. So far, only built-in themes have it enabled and I filed this issue to ask you to opt-in for the Shades of Purple themes as well.

Adoption is easy and there are new cool styling possibilities.

To turn on semantic highlighting for a theme, all you have to do is put "semanticHighlighting": true in the theme's definition file.

There's a good chance that no further change to the theme is needed (thanks to a default mapping from semantic tokens to TextMate scopes (if not, I'd be interested to know, so I can improve the defaults further)).

But, more interestingly, themes can tune and go wild by defining new styling rules against the semantic tokens:

"semanticTokenColors": {
    "variable.readonly": "#ff0000", 
    "parameter": { "fontStyle": "underline" },
    "*.declaration:java": { "fontStyle": "bold" }
}

Check out our Semantic Highlighting Wiki and the Semantic Highlighting Guide for more details and feel free to ping me in this issue if I can help.

Thanks for the great work and looking forward to semantic highlighting in your theme.

ahmadawais commented 4 years ago

Hi Martin,

Nice to see you here. I appreciate the time you took to reach out here. 💜 for the Code team especially in times like these.

We had a conversation about this before on the code repo and I commented since my theme had issues in the highlighting with the semanticHighlighting feature enabled.

Now, I plan to dig deep on my end to see what this entails by enabling it and hopefully improving the syntax by this in the near future.

I'll update you when that happens. It's a bit tough nowadays.